This repository was archived by the owner on Dec 23, 2024. It is now read-only.
chore: release v0.6.0 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Re: the test files, we don't need to worry about that for this PR, but we should get a push-button release workflow in place similar for what was done in metal-go and equinix-sdk-go, and as part of that we should ensure that we're consistent about generating test files or not. We don't use the test files and I doubt we really will, but it's probably easier to generate them all the time than to not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates package version to v0.6.0.
When I run
make generate, a lot of test files were generated. Those files were not generated by the sync GHA, not sure if it's intentional.In the sync GHA, there's
make generate -o patch-spec -o clean, which doesn't generate the test scripts. On the other handmake generateWILL generate the test scripts.