Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@slingamn
Copy link
Member

@slingamn slingamn commented Jun 8, 2025

Updates #2268

@slingamn slingamn added this to the v2.17 milestone Jun 8, 2025
@slingamn slingamn merged commit 9a186f8 into ergochat:master Jun 8, 2025
1 check passed
@ValwareIRC
Copy link
Contributor

Could I ask why you used ACCOUNT_EXISTS for rejecting an invalid nick? According to spec, BAD_ACCOUNT_NAME is for "otherwise invalid"

@slingamn
Copy link
Member Author

slingamn commented Jun 8, 2025

@ValwareIRC just to close the loop here, we do not advertise custom-account-name so you can only register a nickname you are already holding, and in general, anything valid as a nickname is also valid as an account name, so there is no case where we would send BAD_ACCOUNT_NAME. The compatibility issue with force-guest-format is discussed on #2270 but the upshot is that the guest format check in irc/accounts.go is just a final sanity check; the guest prefix should have been stripped before that point, leaving a valid account name.

@slingamn slingamn deleted the register_failcode branch August 17, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants