-
Notifications
You must be signed in to change notification settings - Fork 218
round 1 of follow-up for metadata #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* send an empty batch if necessary, as per spec * reduce lock acquisitions
* max-keys is enforced for channels as well * remove unlimited configurations * maintain the limit exactly without off-by-one cases
Contributor
or two different keys, but yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @thatcher-gaming, possibly of interest (no pressure)
This addresses some of #2274. One area where I am not satisfied is how the spec interacts with persistent clients ("always-on"):
CAP REQtrigger side effectsMETADATA LISTcommand.)SUBduring connection registration (since subs are per-session and they they take effect immediately after connection registration) but we do not necessarily want to acceptSET, which could overwrite metadata that is more authoritative than the client's cached viewSETduring connection registration for anyone?I'm tempted to say that
before-connectshould take a value, either*for unrestricted orsubfor subscription-related commands only.