Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow selection of which metrics to submit from Librato metrics reporter #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ryanlower wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow selection of which metrics to submit from Librato metrics reporter #9

ryanlower wants to merge 1 commit into from

Conversation

@ryanlower
Copy link

@ryanlower ryanlower commented Apr 18, 2012

Can specific :only or :except when initializing the reporter, e.g.

Metriks::Reporter::LibratoMetrics.new(
  'email',
  'key',
  {
    prefix: 'example',
    only: [
      :count,
      :mean,
      :one_minute_rate
    ]
  }
).start

@eric
Copy link
Owner

eric commented Apr 18, 2012

This is great. It may be a couple days before I get a chance to merge and release this — I'm traveling in Japan at the moment... but this looks useful.

Thanks for the pull request.

eric
eric reviewed Apr 25, 2012
View reviewed changes
lib/metriks/reporter/librato_metrics.rb
Copy link
Owner

@eric eric Apr 25, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting these to an empty array is going to cause the if's later on to always evaluate to true.

I think this may be worth a test case to not break things.

@douglasdollars
Copy link

douglasdollars commented Apr 28, 2012

This one is going to really come in handy. Thanks guys!

eric
eric reviewed Jul 3, 2012
View reviewed changes
lib/metriks/reporter/librato_metrics.rb
Copy link
Owner

@eric eric Jul 3, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the defaulting above, this is going to need to be if @only && [email protected]? — same with the @except one.

@JustinLove JustinLove mentioned this pull request Jul 27, 2012
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanlower @eric @douglasdollars