Thanks to visit codestin.com
Credit goes to github.com

Skip to content

beam_ssa_codegen: Don't break bs_match sequences by mixing registers #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhogberg merged 1 commit into from
Jan 3, 2023
Merged

beam_ssa_codegen: Don't break bs_match sequences by mixing registers #6623

jhogberg merged 1 commit into from
Jan 3, 2023

Conversation

@jhogberg
Copy link
Contributor

@jhogberg jhogberg commented Jan 2, 2023

The prefer_xregs subpass sometimes mixed which registers were used for bs_checked_xyz psuedo-instructions, making the bs_translate subpass generate bogus code.

There's nothing wrong with mixing per se though, so we probably want to teach the bs_translate pass how to handle this in the future.

    {bs_match,{f,42},{y,1},{commands,[{ensure_at_least,16,1}]}}.
    {bs_match,{f,0},{x,0},{commands,[{skip,8}]}}.
    {bs_match,{f,42},{x,0},{commands,[{'=:=',nil,8,0},{ensure_exactly,0}]}}.

Fixes #6613

@jhogberg jhogberg added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Jan 2, 2023
@jhogberg jhogberg requested a review from bjorng January 2, 2023 15:34
@jhogberg jhogberg self-assigned this Jan 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023 •
edited
Loading

CT Test Results

       2 files     285 suites   11m 37s ⏱️
   750 tests    748 ✔️ 2 💤 0 ❌
4 654 runs  4 652 ✔️ 2 💤 0 ❌

Results for commit 07697d3.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@jhogberg jhogberg merged commit 08f322d into erlang:master Jan 3, 2023
bjorng added a commit to bjorng/otp that referenced this pull request Jan 30, 2023
@bjorng
Don't break bs_match sequences by mixing registers (again)
7d01f8a 
See erlang#6623 for a fix to a similar bug reported in erlang#6613.

Closes erlang#6755
@bjorng bjorng mentioned this pull request Jan 30, 2023
Merged
josevalim pushed a commit to josevalim/otp that referenced this pull request Jan 30, 2023
@bjorng @josevalim
Don't break bs_match sequences by mixing registers (again)
f3e0f6b 
See erlang#6623 for a fix to a similar bug reported in erlang#6613.

Closes erlang#6755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorng bjorng Awaiting requested review from bjorng

Assignees

@jhogberg jhogberg

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[erlc] internal consistency check failed on bs_match

1 participant

@jhogberg