Thanks to visit codestin.com
Credit goes to github.com

Skip to content

compiler: Various type-related fixes and improvements #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhogberg merged 3 commits into from
Jan 25, 2023
Merged

compiler: Various type-related fixes and improvements #6651

jhogberg merged 3 commits into from
Jan 25, 2023

Conversation

@jhogberg
Copy link
Contributor

@jhogberg jhogberg commented Jan 10, 2023

Fixes #6648

@jhogberg jhogberg added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Jan 10, 2023
@jhogberg jhogberg requested a review from bjorng January 10, 2023 10:47
@jhogberg jhogberg self-assigned this Jan 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023 •
edited
Loading

CT Test Results

       2 files     285 suites   11m 1s ⏱️
   751 tests    749 ✔️ 2 💤 0 ❌
4 655 runs  4 653 ✔️ 2 💤 0 ❌

Results for commit 96a1872.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@RobinMorisset
Copy link
Contributor

RobinMorisset commented Jan 10, 2023

@jhogberg The second commit of this PR (d39cf83) introduces a bug on the following testcase:

start() ->
    <<_V1 || <<_V0/float, _V1:_V0>> <= <<>>>>.

erlc compiles it fine, but it then fails to load in the BEAM, with the following error message:

beam/beam_load.c(172): Error loading module introduced:
  corrupt type table
Error! Failed to load module 'introduced' because it requires a more recent Erlang/OTP version or its .beam file was corrupted.
(You are running Erlang/OTP 26.)

@jhogberg jhogberg force-pushed the john/compiler/propagate-infer-relops-failure/GH-6648 branch from 5e7b131 to fdc1169 Compare January 10, 2023 12:45
@RobinMorisset
Copy link
Contributor

RobinMorisset commented Jan 10, 2023

The new code fails to compile

f(<<_, 0/utf8>>) ->
    ok.

with

Function: f/1
Sub pass ssa_opt_type_start
minimized/new18.erl: internal error in pass beam_ssa_opt:
exception error: no function clause matching beam_ssa_type:bs_match_type(string,
 [{b_var,4},{b_literal,<<0>>}],
 #{{b_var,0} => {t_bs_matchable,1},
   {b_var,3} => {t_bs_context,1},
   {b_var,4} => {t_bs_context,1}}) 
  in function  beam_ssa_type:type/5 (beam_ssa_type.erl, line 2361)
  in call from beam_ssa_type:update_types/3 (beam_ssa_type.erl, line 2046)
  in call from beam_ssa_type:simplify/5 (beam_ssa_type.erl, line 1034)
  in call from beam_ssa_type:sig_is/7 (beam_ssa_type.erl, line 309)
  in call from beam_ssa_type:sig_bs/8 (beam_ssa_type.erl, line 251)
  in call from beam_ssa_type:sig_function_1/4 (beam_ssa_type.erl, line 220)
  in call from beam_ssa_type:do_sig_function/4 (beam_ssa_type.erl, line 168)

@jhogberg
Copy link
Contributor Author

jhogberg commented Jan 10, 2023

I noticed that too soon after pushing -- I had looked at the wrong tab when checking the tests. Happy to see you're on our case so quickly :D

I've pushed a fixed version now.

@jhogberg jhogberg force-pushed the john/compiler/propagate-infer-relops-failure/GH-6648 branch from fdc1169 to 96a1872 Compare January 10, 2023 13:05
This was referenced Jan 10, 2023
Closed
Closed
Closed
Closed
This was referenced Jan 18, 2023
Closed
Closed
@jhogberg jhogberg merged commit 2ca36bd into erlang:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorng bjorng bjorng approved these changes

Assignees

@jhogberg jhogberg

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[erlc] Internal consistency check failed: bad_arg_type

3 participants

@jhogberg @RobinMorisset @bjorng