Thanks to visit codestin.com
Credit goes to github.com

Skip to content

jit: Fix float negation on x64 #6726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhogberg merged 2 commits into from
Jan 26, 2023
Merged

jit: Fix float negation on x64 #6726

jhogberg merged 2 commits into from
Jan 26, 2023

Conversation

@jhogberg
Copy link
Contributor

@jhogberg jhogberg commented Jan 23, 2023

Fixes #6717

@jhogberg jhogberg added team:VM Assigned to OTP team VM fix labels Jan 23, 2023
@jhogberg jhogberg self-assigned this Jan 23, 2023
@jhogberg jhogberg changed the title : Fix float negation discrepancy between jit and emu jit: Fix float negation discrepancy between jit and emu Jan 23, 2023
@jhogberg jhogberg changed the title jit: Fix float negation discrepancy between jit and emu jit: Fix float negation discrepancy between x64 jit and emu Jan 23, 2023
@jhogberg jhogberg changed the title jit: Fix float negation discrepancy between x64 jit and emu jit: Fix float negation on x64 Jan 23, 2023
@jhogberg
jit: Fix float negation on x64
af849f9
@jhogberg
erts: Float negation cannot fail
a7c296d 
Since float negation just flips the sign bit, there is no way to
produce a non-finite number from a finite float.
@jhogberg jhogberg force-pushed the john/erts/fnegate-bug-x86_64/GH-6717/OTP-18411 branch from 3752a63 to a7c296d Compare January 23, 2023 20:35
@jhogberg jhogberg mentioned this pull request Jan 23, 2023
Closed
@jhogberg jhogberg added this to the OTP-25.3 milestone Jan 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

CT Test Results

       3 files     125 suites   43m 50s ⏱️
1 500 tests 1 449 ✔️ 51 💤 0 ❌
1 812 runs  1 743 ✔️ 69 💤 0 ❌

Results for commit a7c296d.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@bjorng bjorng linked an issue Jan 24, 2023 that may be closed by this pull request
[vm] Floating point discrepancy (-0.0 vs +0.0) between -emu_flavor emu and -emu_flavor jit #6717
Closed
@jhogberg jhogberg added the testing currently being tested, tag is used by OTP internal CI label Jan 25, 2023
@jhogberg jhogberg merged commit e2f4bcb into erlang:maint Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jhogberg jhogberg

Labels

fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

OTP-25.3

Development

Successfully merging this pull request may close these issues.

[vm] Floating point discrepancy (-0.0 vs +0.0) between -emu_flavor emu and -emu_flavor jit

1 participant

@jhogberg