Optimize binary_to_term #9759
Merged
Optimize binary_to_term #9759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 141 suites 49m 40s ⏱️ Results for commit c8cd321. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
0cc110d to
c8cd321
Compare
|
Ticket: OTP-19618 |
garazdawi
reviewed
Apr 29, 2025
rickard-green
previously approved these changes
Apr 30, 2025
| DistEntry *dep; | ||
| ErtsDistExternalData *data; | ||
| Uint32 flags; | ||
|
|
Struct ErtsDistExternal contains large atom cache table (64kb) which is not used by binary_to_term and just consumes stack space... ..and CPU if passing compile option -ftrivial-auto-var-init
c8cd321 to
753b6e9
Compare
garazdawi
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of struct
ErtsDistExternalwhich contains a large atom cache table (64kb). The atom cache is not even used bybinary_to_termand just consumes native stack space. With compiler option-ftrivial-auto-var-init=zeroit gets really bad as it zeroes all those 64kb for each call.