Fix code generator to include wx fixes #10314
Open
+37
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetRed, GetBlue, GetGreen in wxWidgets return `unsigned char`, But the code in wxe_wrapper_4.cpp is using `char` to receive the result and sign extending it into a int. As a result, a pixel whose red is `250`(`16#FA`) will be returned as `4294967290`(`16#FFFFFFFA`) by `wxImage:getRed/3`. This commit fixed this problem.
The committed code didn't correspond to what the generator did. Fix generator to produce the correct licenses and fix WXE_WEBVIEW include.
* upstream/pr/10303: wx: Fixed the types of pixel values.
Generate code according to previous commit and add a testcase.
CT Test Results 2 files 17 suites 3m 42s ⏱️ Results for commit 4ec70e8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
u3s
approved these changes
Oct 21, 2025
u3s
previously approved these changes
Oct 24, 2025
gl.erl was compiled with wrong parameters in bootstrap, and then kept in the release, 3rd time I'm fixing this hopefully for real now. If headers/libs are available it should work now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes code generator to generate previous added fixes.
Includes the commit in #10303 and adds a testcase and also fixes the code generator for that code.