Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve output (around "Requested ... version") when we know input #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve output (around "Requested ... version") when we know input #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26066,11 +26066,21 @@ async function getOTPVersion(otpSpec0, osVersion) {
}

function requestedVersionFor(tool, version, originListing, mirrors) {
return (
`Requested ${tool} version (${version}) not found in version list, ` +
`at ${originListing}${mirrors ? `, with mirrors ${mirrors}` : ''}; ` +
"should you be using option 'version-type': 'strict'?"
)
const isStrictVersion = isStrictVersion()

let versionType = 'loose'
if (isStrictVersion) {
versionType = 'strict'
}

let ret =
`Requested ${versionType} ${tool} version (${version}) not found in version list, ` +
`at ${originListing}${mirrors ? `, with mirrors ${mirrors}` : ''}.`
if (!isStrictVersion) {
ret = `${ret} Should you be using option 'version-type': 'strict'?`
}

return ret
}

const knownBranches = ['main', 'master', 'maint']
Expand Down
20 changes: 15 additions & 5 deletions src/setup-beam.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,21 @@ async function getOTPVersion(otpSpec0, osVersion) {
}

function requestedVersionFor(tool, version, originListing, mirrors) {
return (
`Requested ${tool} version (${version}) not found in version list, ` +
`at ${originListing}${mirrors ? `, with mirrors ${mirrors}` : ''}; ` +
"should you be using option 'version-type': 'strict'?"
)
const isStrictVersion = isStrictVersion()

let versionType = 'loose'
if (isStrictVersion) {
versionType = 'strict'
}

let ret =
`Requested ${versionType} ${tool} version (${version}) not found in version list, ` +
`at ${originListing}${mirrors ? `, with mirrors ${mirrors}` : ''}.`
if (!isStrictVersion) {
ret = `${ret} Should you be using option 'version-type': 'strict'?`
}

return ret
}

const knownBranches = ['main', 'master', 'maint']
Expand Down
Loading