Erlang/OTP 29.0-rc1 compilation warnings#507
Closed
alexandrejbr wants to merge 2 commits intoerlyaws:masterfrom
Closed
Erlang/OTP 29.0-rc1 compilation warnings#507alexandrejbr wants to merge 2 commits intoerlyaws:masterfrom
alexandrejbr wants to merge 2 commits intoerlyaws:masterfrom
Conversation
Collaborator
|
Thanks! I probably will merge it, exactly for the reasons you mention. Also, I already have the |
Collaborator
|
I built this locally so I could check it with OTP29-rc1 and found a number of other warnings, so I took your commits, squashed them, made additional fixes, and merged b325cae to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not expecting that this PR is accepted as is since the usages of catch are not fixed and are just being ignored. But maybe it's good enough for some initial testing to be done with Erlang/OTP-29 and then the catch rewrite can be done later.
Fixes #506