refactor: use importlib instead of pkg_resources #1669
Merged
+70
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c6a993 to
26297d9
Compare
8056027 to
d0d8e8a
Compare
eb945af to
f6aefee
Compare
I needed to further adjust the files lookup to ignore distributions that were not found.
f6aefee to
4230370
Compare
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* refactor: use importlib instead of pkg_resources * fix: remove try/except import check for importlib * fix: workaround to support python 3.9 and older * tests: add basic entry_point_plugins tests I needed to further adjust the files lookup to ignore distributions that were not found. * docs: add info to CHANGES (cherry picked from commit 363f01f)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* refactor: use importlib instead of pkg_resources * fix: remove try/except import check for importlib * fix: workaround to support python 3.9 and older * tests: add basic entry_point_plugins tests I needed to further adjust the files lookup to ignore distributions that were not found. * docs: add info to CHANGES (cherry picked from commit 363f01f)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* refactor: use importlib instead of pkg_resources * fix: remove try/except import check for importlib * fix: workaround to support python 3.9 and older * tests: add basic entry_point_plugins tests I needed to further adjust the files lookup to ignore distributions that were not found. * docs: add info to CHANGES (cherry picked from commit 363f01f)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* refactor: use importlib instead of pkg_resources * fix: remove try/except import check for importlib * fix: workaround to support python 3.9 and older * tests: add basic entry_point_plugins tests I needed to further adjust the files lookup to ignore distributions that were not found. * docs: add info to CHANGES (cherry picked from commit 363f01f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to use importlib vs pkg_resources for processing packages as plugins.