• X
• Mastodon
• LinkedIn
• Facebook

backend/plugins/frontline_api/src/modules/integrations/facebook/utils.ts (4)

112-117: Cache design: add single-flight to prevent parallel config fetches

isFetchingConfig + current condition allows multiple concurrent fetches when cache is empty/expired. Use a pending promise to dedupe requests.

-type UploadConfig = { AWS_BUCKET: string };
-let cachedUploadConfig: UploadConfig | null = null;
-let isFetchingConfig = false; // Concurrency control
-let lastFetchTime = 0; // Time-based cache invalidation
-const CACHE_TTL_MS = 5 * 60 * 1000; // 5 minutes
+type UploadConfig = {
+  AWS_BUCKET: string;
+  AWS_ACCESS_KEY_ID?: string;
+  AWS_SECRET_ACCESS_KEY?: string;
+  AWS_COMPATIBLE_SERVICE_ENDPOINT?: string;
+  AWS_FORCE_PATH_STYLE?: string | boolean;
+  UPLOAD_SERVICE_TYPE?: string;
+};
+let cachedUploadConfig: UploadConfig | null = null;
+let pendingUploadConfig: Promise<UploadConfig> | null = null; // single-flight
+let lastFetchTime = 0;
+const CACHE_TTL_MS = 5 * 60 * 1000; // 5 minutes

---

127-149: Deduplicate TRPC config fetches and harden error handling

Make fetch single-flight and await the same promise; avoid stampede and ensure consistent null handling.

-  if (
-    !cachedUploadConfig ||
-    (Date.now() - lastFetchTime > CACHE_TTL_MS && !isFetchingConfig)
-  ) {
-    try {
-      isFetchingConfig = true;
-      cachedUploadConfig = await sendTRPCMessage({
-        subdomain,
-        pluginName: 'core',
-        method: 'query',
-        module: 'configs',
-        action: 'getFileUploadConfigs',
-        input: {},
-      });
-      lastFetchTime = Date.now();
-    } catch (err) {
-      debugError(`Failed to fetch upload config: ${err.message}`);
-      return null;
-    } finally {
-      isFetchingConfig = false;
-    }
-  }
+  if (!cachedUploadConfig || Date.now() - lastFetchTime > CACHE_TTL_MS) {
+    if (!pendingUploadConfig) {
+      pendingUploadConfig = sendTRPCMessage({
+        subdomain,
+        pluginName: 'core',
+        method: 'query',
+        module: 'configs',
+        action: 'getFileUploadConfigs',
+        input: {},
+      })
+        .then((cfg) => {
+          cachedUploadConfig = cfg as UploadConfig;
+          lastFetchTime = Date.now();
+          return cachedUploadConfig!;
+        })
+        .catch((err) => {
+          debugError(
+            `Failed to fetch upload config: ${
+              err instanceof Error ? err.message : String(err)
+            }`,
+          );
+          throw err;
+        })
+        .finally(() => {
+          pendingUploadConfig = null;
+        });
+    }
+    try {
+      await pendingUploadConfig;
+    } catch {
+      return null;
+    }
+  }

---

158-189: Reuse S3 client per subdomain; avoid per-call init

createAWS re-fetches configs and instantiates S3 on every upload. Memoize an S3 instance keyed by subdomain/config fingerprint to cut latency and load. Also derive content-type/extension from response headers instead of a boolean flag.

-  const { AWS_BUCKET } = cachedUploadConfig;
+  const { AWS_BUCKET } = cachedUploadConfig;
   try {
-    const s3 = await createAWS(subdomain);
+    const s3 = await createAWS(subdomain); // consider memoizing per subdomain
@@
-      const response = await fetch(url, {
+      const response = await fetch(url, {
         signal: controller.signal,
         redirect: 'error', // Prevent redirects that could bypass our validation
       });
 
       if (!response.ok) throw new Error(`HTTP ${response.status}`);
 
-      const buffer = Buffer.from(await response.arrayBuffer());
+      const contentType =
+        response.headers.get('content-type') || (video ? 'video/mp4' : 'image/jpeg');
+      const ext = (contentType.split('/')[1] || '').split(';')[0] || (video ? 'mp4' : 'jpg');
+      const mediaFile = `uploads/${randomAlphanumeric(16)}.${ext}`;
+      const buffer = Buffer.from(await response.arrayBuffer());
       const data = await s3
         .upload({
           Bucket: AWS_BUCKET,
           Key: mediaFile,
           Body: buffer,
           ACL: 'public-read',
-          ContentType: video ? 'video/mp4' : 'image/jpeg',
+          ContentType: contentType,
         })
         .promise();

---

195-200: Invalidate pending promise too

Clear the in-flight promise on manual invalidation to avoid resolving stale data.

 export const invalidateUploadConfigCache = () => {
   cachedUploadConfig = null;
   lastFetchTime = 0;
+  pendingUploadConfig = null;
 };

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro