Migrate exml attributes from proplists to maps#74
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 73.87% 73.92% +0.04%
==========================================
Files 7 7
Lines 1183 1189 +6
Branches 169 169
==========================================
+ Hits 874 879 +5
- Misses 309 310 +1 ☔ View full report in Codecov by Sentry. |
0f20d46 to
7fc1219
Compare
jacekwegr
reviewed
Dec 20, 2024
jacekwegr
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 I really like the new utility functions added! I just have one minor comment
src/exml.erl
Outdated
| xml_sort(Elements) when is_list(Elements) -> | ||
| lists:sort([ xml_sort(E) || E <- Elements ]). | ||
|
|
||
| %% @doc Return the given `t:element/0' without any `t:cdata/0' on its children. |
There was a problem hiding this comment.
I'm not sure this comment is entirely correct
Collaborator
Author
There was a problem hiding this comment.
Oh, copy-paste from the function below, fixing in a sec!
7fc1219 to
7495721
Compare
jacekwegr
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could be creating a new version that returns the attributes in a map instead of a proplist, and exports getters in line with
maps:with/2andmaps:without/2.