Allow adding new attributes while using jerboa as a dep #84
Conversation
This is based on the regular protocol dispatching for the Encoder protocol and configuration-driven function clauses generation for the Decoder protocol.
There was a problem hiding this comment.
It looks good, although I see one issue with this approach. In order to extend our enc/decoder, one has to implement both Encoder and Decoder protocols. But after implementing Encoder (and type_code callback), developer needs to pass the same type code to Jerboa's config. What do you think about removing type_code callback from Encoder, and rely on type codes passed independently of protocol to function generator, just like we do with external attributes?
That was a duplication.
677b655 to
3c80efa
Compare
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 18 commits behind the You can see more details about this review at https://ebertapp.io/github/esl/jerboa/pulls/84. |
|
@arkgil for me it looks worse now. I liked it more with I'm not convinced we would want to merge that. |
This is based on the regular protocol dispatching for the Encoder protocol
and configuration-driven function clauses generation for the Decoder protocol.