Implement HTTP transport using SSE, Protocol 2024-11-05 (Final)#5
Merged
Conversation
fdb3d65 to
3f37e72
Compare
Owner
|
Can you update the README as well? |
3f37e72 to
af9546c
Compare
Author
Done 👍 Also fixed the linter errors. |
af9546c to
55c8682
Compare
Owner
|
Perfect! |
Owner
|
Can you fix the lint errors? |
Signed-off-by: Doğaç Eldenk <[email protected]>
55c8682 to
e74d14f
Compare
Author
I also found that
Let me know if you want to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the HTTP transport using SSE. The CLI tool automatically determines whether the connection is an http or stdio by checking the command's arguments. If it is only 1 argument and starts with
http://orhttps://, it uses HTTP instead of stdio.Hi Fatih, this project looks pretty cool, MCP is relatively new and I wanted to contribute. It's been a while since I have written Go so let me know if anything looks odd.
Also, I have implemented the solution based on "Final" edition. The "Latest" version actually changed quite a bit of things, it is much more complicated and I couldn't find any example project that used the new protocol (TBH I did not search hard enough).
https://spec.modelcontextprotocol.io/specification/2025-03-26/basic/transports/
Type of change
How Has This Been Tested?
I have run the "everything" MCP server using a docker image,
Later, I have conducted the test manually by calling the existing functionality,
Screen.Recording.2025-03-26.at.22.14.54.mov
I belive there might be some kind of bug with tool calls in shell mode, I couldn't make it work.
Checklist: