Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a better table view along with improved terminal width handling and text wrapping for various output formats. Key changes include:
- Addition of tests for text wrapping, terminal width detection, and tools list formatting.
- Enhancement of table formatting for tools, prompts, and resources with dynamic column widths and proper text wrapping.
- Updates to command help messages in the CLI to use simplified example paths.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/jsonutils/jsonutils_test.go | Added tests for wrapText, getTermWidth, and tools list formatting. |
| pkg/jsonutils/jsonutils.go | Improved table formatting with dynamic widths and added helper functions. |
| cmd/mcptools/main.go | Updated example command output to use a simplified path. |
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
pkg/jsonutils/jsonutils_test.go:176
- In TestParseFormat, the ordering of test case values appears reversed relative to the field definitions (input string and expected OutputFormat). Verify that the first field indeed represents the input and the second field the expected output for clarity and consistency.
{FormatJSON, "json"},
cmd/mcptools/main.go:538
- [nitpick] Ensure that the command naming in help messages is consistent across the application; consider verifying that 'mcp tools shell' aligns with the naming conventions used in other commands.
fmt.Println("mcp tools shell")
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: