fix: resolve all golangci-lint issues #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract parseCallArgs() to reduce cyclomatic complexity in call.go - Convert if-else chain to switch in new.go - Add exported transport constants (TransportSSE, TransportHTTP, TransportStdio) - Use entity type constants instead of string literals in web.go - Use transport constants instead of string literals in utils.go - Fix gofmt formatting issues in root.go, utils.go, transport_test.go - Fix empty-block by inverting condition in utils.go - Add nolint directive for GetSessionId (required by mcp-go interface)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all pre-existing golangci-lint issues that were causing CI failures.
Changes
parseCallArgs()helper function in call.go to reduce cyclomatic complexityTransportSSE,TransportHTTP,TransportStdio) to root.go and use them throughoutGetSessionId- method name is required bytransport.Interfacefrom mcp-goNotes
The
GetSessionIdnaming issue cannot be fixed without changes to the upstream mcp-go library, as it defines the interface method with that name. Added a nolint directive with explanation.Testing
golangci-lint runnow reports 0 issues