Add configurable portfolio #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice job @AdamZsofi ! I did not check the Perl scripts in detail because I'm not an expert. But seems like they are well structured. I focused more on the user's side, I did some refactoring/improvements in the documentation. I also bumped the version number. I'll wait for the CI to pass, then I'll do the merge. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deletes the old, hardcoded starter & portfolio script and adds a new, configurable one, which can be found under /scripts/portfolio. Example YAML configuration files and input files are also there.
Documentation is under /doc/portfolio.md (usage and features are both documented).
I also extended the functional tests with a few portfolio tests (these can be extended with more in the future), here.
The Dockerfile was also edited so portfolios can also be run on the docker machines.