Merged
Conversation
6a0fdb4 to
4ebb88c
Compare
dragonsinth
reviewed
Sep 30, 2019
cmd/grpcurl/grpcurl.go
Outdated
| protosetOut = flags.String("protoset-out", "", prettify(` | ||
| The name of a file to be written that will contain a FileDescriptorSet | ||
| proto. With the list and describe verbs, the listed or described | ||
| elements, and their transitive dependencies, will be written to the |
Member
There was a problem hiding this comment.
I think you can remove both these commas?
dragonsinth
reviewed
Sep 30, 2019
desc_source.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func addFilesToSet(seen map[string]struct{}, fds *[]*descpb.FileDescriptorProto, fd *desc.FileDescriptor) { |
Member
There was a problem hiding this comment.
could follow more normal append pattern, e.g. `allFilesSlice = addFilesToSet(allFilesSlice, expandedFiles, fds[filename])
dragonsinth
approved these changes
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #118
This allows use of grpcurl to save protoset files of the descriptors that it resolves using service reflection. When doing
grpcurl <endpoint> list, this will save a protoset file that has the definitions for all of the services that the given endpoint exposes (assuming it supports server reflection).