Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@erikjoh
Copy link
Contributor

@erikjoh erikjoh commented Jun 23, 2020

@jhump Version 1.30.0 introduces the new xds scheme and some nice improvements to xds in general.

@erikjoh erikjoh closed this Jul 4, 2020
@erikjoh erikjoh reopened this Jul 4, 2020
@menghanl
Copy link

menghanl commented Jul 8, 2020

Thanks @erikjoh, I was going to send a PR.

This change is similar to #136 (+ #137).
It will be great if we can merge this, and make a new release with binaries.
Thanks a lot!

@erikjoh
Copy link
Contributor Author

erikjoh commented Jul 13, 2020

Ping @jhump

Copy link
Contributor

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was neglected for a couple of weeks. Thanks for the contribution!

Is there anything in particular I should say about this change in the release notes?

@jhump jhump merged commit b8c67b7 into fullstorydev:master Jul 13, 2020
@menghanl
Copy link

Thanks @jhump
Something to mention the stable scheme would be great.

  • add support for specifying target using "xds" scheme ("xds:///example.com", the stable version of "xds-experimental:///example.com") for xDS service discovery.

@jhump
Copy link
Contributor

jhump commented Jul 13, 2020

@menghanl, does this remove support for the "xds-experimental" scheme? Or does this new non-experimental package register resolvers for both schemes?

@menghanl
Copy link

This release support both schemes, "xds" and "xds-experimental" (and both packages, with and without experimental).
Plan is to remove experimental in the next release.

@jhump
Copy link
Contributor

jhump commented Jul 14, 2020

FYI, @menghanl and @erikjoh, I've created a release which includes this change: v1.6.1. That includes publishing a new docker image as well as opening a PR to update homebrew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants