remove VersionDirectory from libraries (beta-3.0) #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before when building libraries, output files were placed inside a
directory named after the current version of the library, e.g.
lib/build/UnoCore/1.2.3/
This is a relic from a time where it was possible to install multiple
versions of the same library side by side using Uno Package Manager.
Uno Package Manager was removed in favor of NPM in 2019, so we no longer
have this requirement and can remove the last directory part, e.g.
lib/build/UnoCore/
We should still be able to load libraries built by older versions of
Uno using the version directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when building libraries, output files were placed inside a directory named after the current version of the library, e.g.
This is a relic from a time where it was possible to install multiple versions of the same library side by side using Uno Package Manager.
Uno Package Manager was removed in favor of NPM in 2019, so we no longer have this requirement and can remove the last directory part, e.g.
We should still be able to load libraries built by older versions of Uno using the version directory.