Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@somiaj
Copy link
Collaborator

@somiaj somiaj commented Dec 10, 2024

The dashed line GC is set before user options are parsed, so only newly created DeskStyles will have the dashed_gc set to a solid line. This means that when showing multiple desks, no desks will have a solid line, or when showing the current desk, the initial desk will not have a solid line, but other desks will.

The label_gc uses the same fg color as dashed_gc, and can be used to create solid lines. So instead of relying on dashed_gc to know if solid lines should be used or not, use either label_gc or dashed_gc to draw the separators depending on if the option SolidSeparators is used or not.

Fixes #1138

The dashed line GC is set before user options are parsed, so
only newly created DeskStyles will have the dashed_gc set to
a solid line. This means that when showing multiple desks, no
desks will have a solid line, or when showing the current desk,
the initial desk will not have a solid line, but other desks
will.

The label_gc uses the same fg color as dashed_gc, and can be used
to create solid lines. So instead of relying on dashed_gc to know
if solid lines should be used or not, use either label_gc or
dashed_gc to draw the separators depending on if the option
SolidSeparators is used or not.

Fixes #1138
@ThomasAdam ThomasAdam self-assigned this Dec 10, 2024
@ThomasAdam ThomasAdam added type:bug Something's broken! relates:module Issue is in module code labels Dec 10, 2024
@ThomasAdam ThomasAdam added this to the 1.1.2 milestone Dec 10, 2024
@ThomasAdam ThomasAdam merged commit a6119f4 into main Dec 10, 2024
12 checks passed
@ThomasAdam ThomasAdam deleted the js/gh-1138 branch December 10, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relates:module Issue is in module code type:bug Something's broken!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

FvwmPager: The SolidSeparators option doesn't affect the first desk shown or multiple desks

2 participants