fix monitor position conflicts when a monitor is disabled #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
reviewed
Oct 12, 2025
fvwm/move_resize.c
Outdated
| { | ||
| if (fw->m == m) | ||
| continue; | ||
| if ((m->flags & MONITOR_DISABLED) != 0) |
ThomasAdam
reviewed
Oct 12, 2025
fvwm/move_resize.c
Outdated
| wa.height = fw->m->Desktops->ewmh_working_area.height; | ||
| } | ||
|
|
||
| fvwm_debug("move_resize", "monitor %s flag 0x%x wa %d+%d %dx%d\n", fw->m->si->name, fw->m->flags, wa.x, wa.y, wa.width, wa.height); |
ThomasAdam
reviewed
Oct 12, 2025
libs/FScreen.c
Outdated
| if (nr_monitors > 0 && strcmp(m->si->name, GLOBAL_SCREEN_NAME) == 0) | ||
| continue; | ||
|
|
||
| fvwm_debug("FindScreenOfXY", "monitor %s flag 0x%x\n", |
ThomasAdam
requested changes
Oct 12, 2025
There was a problem hiding this comment.
Hi @mikeandmore -- this all looks fine, just so minor changes before I merge this, please.
|
Thanks -- you just need to squash these two commits, please. |
If a monitor is disabled, its key in the rbtree should change so that it won't conflict with enabled monitors. Searching for the next available monitor should skip disabled monitors too.
4a55f66 to
2b0b5a2
Compare
|
@ThomasAdam squashed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a monitor is disabled, its key in the rbtree should change so that it won't conflict with enabled monitors.
Searching for the next available monitor should skip disabled monitors too.
This PR fixed this issue.