Hughsie/elantp forcetable #9800
Merged
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
88100c2 to
ea6dd64
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Elan touchpad firmware updates with improved forcetable handling, support for new IC types (0x14 and 0x15), and a new IAP password for version 7.
Changes:
- Added support for IC types 0x14 and 0x15 with appropriate password handling and forcetable address logic
- Implemented early firmware write termination when
ETP_FW_IAP_END_WAITWDTflag is detected - Relaxed firmware validation to allow 0xFFFF as a valid value instead of treating values > 0x7FFF as invalid
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| plugins/elantp/fu-elantp-common.h | Added new IAP password constant for version 7 and new status flag for early termination |
| plugins/elantp/fu-elantp-firmware.c | Relaxed validation bounds to accept 0xFFFF values for IAP and module addresses |
| plugins/elantp/fu-elantp-hid-device.c | Extended device support for IC types 0x14/0x15, improved forcetable handling, and implemented early write termination |
| plugins/elantp/fu-elantp-i2c-device.c | Implemented early write termination when watchdog timer flag is set |
Member
Author
|
@jinglewu can you have a look at some of the copilot-found issues please? |
Co-authored-by: Copilot <[email protected]>
…the current iteration. Co-authored-by: Copilot <[email protected]>
jinglewu
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request: