Fix detection of added/removed files when a directory is moved or cloned#1660
Open
Fix detection of added/removed files when a directory is moved or cloned#1660
Conversation
Summary: Adds optional mutation tracking to FileSystem's mutation methods via a FileSystemListener parameter, and add an implementation that aggregates *net* changes into a batch. The three file change maps are mutually exclusive, as are the two directory change sets. Differential Revision: D92006310
…rocessing Differential Revision: D92047480
…mmediately before each emit Differential Revision: D92008990
…ngeAggregator and reduce duplication Differential Revision: D93984442
…ngeAggregator and reduce duplication
Summary:
Adds utility methods to FileSystemChangeAggregator:
- isEmpty(): checks if there are any changes tracked
- getMappedView(): returns a view with metadata transformed by a mapping function
- Local mapIterable helper for the transformation
These methods support cleaner code when consuming file system changes.
Adds a new `changes` field to ChangeEvent with structured file system change metadata.
- Updates ChangeEvent type to include `changes: ReadonlyFileSystemChanges<{isSymlink: boolean}>`
- Marks `eventsQueue` as deprecated
- Uses getMappedView() to efficiently provide plugin-specific and public change views
- Updates tests to verify the new changes field with isSymlink metadata
Differential Revision: D94076918
…ventsQueue, update tests to use new API Differential Revision: D94077032
…s` rather than `eventsQueue` Differential Revision: D94077082
…Queue Differential Revision: D94080398
Differential Revision: D94362228
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D94362228