Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed redundant curr_node.get_child_node call in get_child_azks_element_in_dir #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinlewi merged 2 commits into from
May 27, 2025
Merged

Removed redundant curr_node.get_child_node call in get_child_azks_element_in_dir #461

kevinlewi merged 2 commits into from
May 27, 2025

Conversation

@cryo28
Copy link
Contributor

@cryo28 cryo28 commented May 12, 2025

This code is duplicate and is not required

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (3ce5335) to head (612ff2b).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
akd/src/storage/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   88.61%   89.73%   +1.11%     
==========================================
  Files          39       38       -1     
  Lines        9109     8423     -686     
==========================================
- Hits         8072     7558     -514     
+ Misses       1037      865     -172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cryo28 cryo28 force-pushed the main branch 3 times, most recently from 0b29e00 to 44f3b5c Compare May 13, 2025 15:30
kevinlewi
kevinlewi approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

I wonder also if it is time to release a 0.12.0 (instead of the pre-releases).

Do you mind modifying the appropriate lines + consolidating the changelog? Or alternatively I would be happy to do this in a follow-up diff, but if you can undo your edits that mark the 0.12.0-pre.11 -> 0.12.0-pre.12 changes, that would be great!

@cryo28
Copy link
Contributor Author

cryo28 commented May 13, 2025

I have another minor change pending at this moment. Dillon was going to canary it on today and see the impact. So, let's wait for the release a little bit more.

kevinlewi
kevinlewi approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can update the version in a separate PR

@kevinlewi kevinlewi merged commit 04d1988 into facebook:main May 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

@dillongeorge dillongeorge dillongeorge approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cryo28 @codecov-commenter @kevinlewi @dillongeorge @facebook-github-bot