Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dillongeorge
Copy link
Contributor

As the title states, this fixes some clippy issues which were impacting CI.

For example: https://github.com/facebook/akd/actions/runs/16900068262/job/47877320987.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
As the title states, this fixes some clippy issues which were impacting CI.

For example: https://github.com/facebook/akd/actions/runs/16900068262/job/47877320987.
Copy link
Contributor

@slawlor slawlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint all the things!

@dillongeorge dillongeorge marked this pull request as ready for review August 26, 2025 18:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.91%. Comparing base (3ce5335) to head (206cb3d).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
akd/src/storage/manager/mod.rs 0.00% 1 Missing ⚠️
akd/src/storage/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   88.61%   88.91%   +0.29%     
==========================================
  Files          39       38       -1     
  Lines        9109     7488    -1621     
==========================================
- Hits         8072     6658    -1414     
+ Misses       1037      830     -207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dillongeorge dillongeorge merged commit 94bd3dc into facebook:main Aug 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants