Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reorganizing test files #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinlewi merged 1 commit into from
Jul 4, 2024
Merged

Reorganizing test files #439

kevinlewi merged 1 commit into from
Jul 4, 2024

Conversation

@kevinlewi
Copy link
Contributor

@kevinlewi kevinlewi commented Jun 25, 2024 •
edited
Loading

No functional changes, just moves all of the existing tests out of the 1500-line file akd/src/tests.rs into a new folder, split under:

  • akd/src/tests/mod.rs
  • akd/src/tests/test_core_protocol.rs
  • akd/src/tests/test_errors.rs
  • akd/src/tests/test_preloads.rs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (3ce5335) to head (cf9a6af).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   88.61%   87.86%   -0.76%     
==========================================
  Files          39       38       -1     
  Lines        9109     8165     -944     
==========================================
- Hits         8072     7174     -898     
+ Misses       1037      991      -46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinlewi kevinlewi marked this pull request as ready for review June 25, 2024 21:30
dillongeorge
dillongeorge approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@dillongeorge dillongeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @kevinlewi ! It makes parsing the tests a lot more friendly for readers.

Not a blocker, but do you think it makes sense to drop the test_ prefix on the individual files since they're already in the test directory/module? We'd then have something like tests/core_protocol.rs. Feels slightly redundant as is, but I'm fine with keeping it if you prefer it that way!

@kevinlewi
Copy link
Contributor Author

kevinlewi commented Jul 4, 2024

I also went back and forth between keeping or dropping the test_ prefix... ultimately decided to keep it since some filenames might be ambiguous, e.g. tests/test_errors.rs versus tests/errors.rs, the latter might be potentially misinterpreted.

I'll land as-is, but I also don't feel super strongly either way :P

@kevinlewi kevinlewi merged commit 7eb4752 into facebook:main Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dillongeorge dillongeorge dillongeorge approved these changes

@afterdusk afterdusk Awaiting requested review from afterdusk

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinlewi @codecov-commenter @dillongeorge @facebook-github-bot