Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade mysql_async and tokio #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eozturk1 merged 30 commits into from
Dec 7, 2021
Merged

Upgrade mysql_async and tokio #94

eozturk1 merged 30 commits into from
Dec 7, 2021

Conversation

@eozturk1
Copy link
Contributor

@eozturk1 eozturk1 commented Dec 7, 2021 •
edited
Loading

This branch upgrades mysql_async to version 0.28.1 and tokio to 1.10.2. Outputs for the following have been tested:

Build:
cargo build

Formatting:
cargo fmt
cargo clippy

Test Plan:
cargo test

cd poc
cargo run
> publish test test

eozturk1 added 29 commits December 1, 2021 16:47
@eozturk1
Upgrade mysql_async
d03b5b7
@eozturk1
Use mysql_async public errors
719f58a
@eozturk1
Update Transaction lifetime
b93d88e
@eozturk1
Update Opts usage
b178fbd
@eozturk1
Update connection usage
3c82d5f
@eozturk1
Update query_drop usage along with associated transactions
793f2a7
@eozturk1
Update query_drop usage along with associated transactions
c7fc899
@eozturk1
Update opts usage
0f398dd
@eozturk1
Make connection and transaction mutable
556a9a2
@eozturk1
Update storage-level errors
1ac8a98
@eozturk1
Update async database lifetime
8515bd7
@eozturk1
Update error types and handling
4da02c1
@eozturk1
Use *_iter versions of functions
a73a039
@eozturk1
Use *_exec versions of functions
0c26e12
@eozturk1
Update connection and transaction (re-)use
2565954
@eozturk1
Fix Result confusion with mysql_async
e963efb
@eozturk1
Update returned result from query_first
19aada5
@eozturk1
Update reduce_and_drop usage
27a7b54
@eozturk1
Reformat with cargo
15853bb
@eozturk1
Update mysql_async error usage of tests
b1ed6cd
@eozturk1
Upgrade Tokio
fc34aa2
@eozturk1
Merge branch 'MySQLTokioUpgrade' of https://github.com/eozturk1/akd i…
ff7319d 
…nto MySQLTokioUpgrade
@eozturk1
Merge remote-tracking branch 'upstream/main' into MySQLTokioUpgrade
d800f46
@eozturk1
Upgrade mysql_async for integration tests
5c550fc
@eozturk1
Make cleanup function visible from the tests
45af8c9
@eozturk1
Update poc tokio version
6d27383
@eozturk1
Remove unneeded mysql_async::Params::from calls
17773ce
@eozturk1
Remove unneeded mysql_async::Params::from calls
0c78862
@eozturk1
Merge branch 'MySQLTokioUpgrade' of https://github.com/eozturk1/akd i…
8d955ce 
…nto MySQLTokioUpgrade
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2021
@slawlor
Copy link
Contributor

slawlor commented Dec 7, 2021

Hmm the integration tests are failing in the CI. Are they failing on your side as well?

@slawlor
Copy link
Contributor

slawlor commented Dec 7, 2021

Everything in the PR looks fine to me, so I'd just want to see why the integration tests are failing (make sure you have docker up and running before starting the test suite). Additionally you should be able to take a look at the integration tests logfile for more debug info if needed. Let me know if you need any help!

@slawlor slawlor self-requested a review December 7, 2021 17:31
slawlor
slawlor requested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@slawlor slawlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to address the test infra failures before merging. Just a suggestion, but make sure the docker container is up and running before running cargo test with

docker compose up -d

@eozturk1
Copy link
Contributor Author

eozturk1 commented Dec 7, 2021

Missed upgrading tokio in one of the Cargo files. (Interestingly, all tests were passing on my machine.) All tests pass now.

In the future, would it be better to combine these Cargo files -- unless we need separate ones for tests, akd, poc etc.?

@eozturk1 eozturk1 merged commit ae66220 into facebook:main Dec 7, 2021
@slawlor
Copy link
Contributor

slawlor commented Dec 7, 2021

Yeah each package needs it's own Cargo file. We have a common one which is referred to as a "workspace" however we don't want a single global one since it impacts the necessary dependencies when published to [crates.io]. If we do that, then someone who wants just an in-memory AKD will need all the mysql dependencies, etc. This keeps it as lean as possible in the published crates, and users pull just what they need.

@eozturk1 eozturk1 deleted the MySQLTokioUpgrade branch December 7, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slawlor slawlor slawlor approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eozturk1 @slawlor @facebook-github-bot