Fix missing #include <limits> #1482
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d765bb to
bfa4743
Compare
There was a problem hiding this comment.
@Orvid has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
dotconnor
pushed a commit
to 5448C8/folly
that referenced
this pull request
Mar 19, 2021
Summary:
Hello,
The compilation with the HEAD of gcc 11 fails:
```
FAILED: CMakeFiles/folly_base.dir/folly/TimeoutQueue.cpp.o
g++ ... -c ../folly/TimeoutQueue.cpp
../folly/TimeoutQueue.cpp: In member function 'int64_t folly::TimeoutQueue::nextExpiration() const':
../folly/TimeoutQueue.cpp:39:32: error: 'numeric_limits' is not a member of 'std'
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~~~~~~~~~~~~
../folly/TimeoutQueue.cpp:39:54: error: expected primary-expression before '>' token
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^
../folly/TimeoutQueue.cpp:39:57: error: '::max' has not been declared
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~
../folly/TimeoutQueue.cpp:39:57: note: suggested alternatives:
In file included from /opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/functional:65,
from ../folly/TimeoutQueue.h:31,
from ../folly/TimeoutQueue.cpp:17:
/opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/bits/stl_algo.h:3464:5: note: 'std::max'
3464 | max(initializer_list<_Tp> __l, _Compare __comp)
| ^~~
```
It is nothing to fix.
Regards,
Laurent
Pull Request resolved: facebook#1482
Reviewed By: yfeldblum
Differential Revision: D24757105
Pulled By: Orvid
fbshipit-source-id: 8a5382edbe5b7c11cace5a1cd4c0645dfd2a9d37
liubang
added a commit
to algo-data-platform/LaserDB
that referenced
this pull request
May 22, 2022
day253
pushed a commit
to ishumei/folly
that referenced
this pull request
Jun 1, 2024
Summary:
Hello,
The compilation with the HEAD of gcc 11 fails:
```
FAILED: CMakeFiles/folly_base.dir/folly/TimeoutQueue.cpp.o
g++ ... -c ../folly/TimeoutQueue.cpp
../folly/TimeoutQueue.cpp: In member function 'int64_t folly::TimeoutQueue::nextExpiration() const':
../folly/TimeoutQueue.cpp:39:32: error: 'numeric_limits' is not a member of 'std'
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~~~~~~~~~~~~
../folly/TimeoutQueue.cpp:39:54: error: expected primary-expression before '>' token
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^
../folly/TimeoutQueue.cpp:39:57: error: '::max' has not been declared
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~
../folly/TimeoutQueue.cpp:39:57: note: suggested alternatives:
In file included from /opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/functional:65,
from ../folly/TimeoutQueue.h:31,
from ../folly/TimeoutQueue.cpp:17:
/opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/bits/stl_algo.h:3464:5: note: 'std::max'
3464 | max(initializer_list<_Tp> __l, _Compare __comp)
| ^~~
```
It is nothing to fix.
Regards,
Laurent
Pull Request resolved: facebook#1482
Reviewed By: yfeldblum
Differential Revision: D24757105
Pulled By: Orvid
fbshipit-source-id: 8a5382edbe5b7c11cace5a1cd4c0645dfd2a9d37
day253
pushed a commit
to ishumei/folly
that referenced
this pull request
Jun 1, 2024
Summary:
Hello,
The compilation with the HEAD of gcc 11 fails:
```
FAILED: CMakeFiles/folly_base.dir/folly/TimeoutQueue.cpp.o
g++ ... -c ../folly/TimeoutQueue.cpp
../folly/TimeoutQueue.cpp: In member function 'int64_t folly::TimeoutQueue::nextExpiration() const':
../folly/TimeoutQueue.cpp:39:32: error: 'numeric_limits' is not a member of 'std'
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~~~~~~~~~~~~
../folly/TimeoutQueue.cpp:39:54: error: expected primary-expression before '>' token
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^
../folly/TimeoutQueue.cpp:39:57: error: '::max' has not been declared
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~
../folly/TimeoutQueue.cpp:39:57: note: suggested alternatives:
In file included from /opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/functional:65,
from ../folly/TimeoutQueue.h:31,
from ../folly/TimeoutQueue.cpp:17:
/opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/bits/stl_algo.h:3464:5: note: 'std::max'
3464 | max(initializer_list<_Tp> __l, _Compare __comp)
| ^~~
```
It is nothing to fix.
Regards,
Laurent
Pull Request resolved: facebook#1482
Reviewed By: yfeldblum
Differential Revision: D24757105
Pulled By: Orvid
fbshipit-source-id: 8a5382edbe5b7c11cace5a1cd4c0645dfd2a9d37
day253
pushed a commit
to ishumei/folly
that referenced
this pull request
Jun 1, 2024
Summary:
Hello,
The compilation with the HEAD of gcc 11 fails:
```
FAILED: CMakeFiles/folly_base.dir/folly/TimeoutQueue.cpp.o
g++ ... -c ../folly/TimeoutQueue.cpp
../folly/TimeoutQueue.cpp: In member function 'int64_t folly::TimeoutQueue::nextExpiration() const':
../folly/TimeoutQueue.cpp:39:32: error: 'numeric_limits' is not a member of 'std'
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~~~~~~~~~~~~
../folly/TimeoutQueue.cpp:39:54: error: expected primary-expression before '>' token
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^
../folly/TimeoutQueue.cpp:39:57: error: '::max' has not been declared
39 | timeouts_.empty() ? std::numeric_limits<int64_t>::max()
| ^~~
../folly/TimeoutQueue.cpp:39:57: note: suggested alternatives:
In file included from /opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/functional:65,
from ../folly/TimeoutQueue.h:31,
from ../folly/TimeoutQueue.cpp:17:
/opt/1A/toolchain/x86_64-v21.0.8/include/c++/11.0.0/bits/stl_algo.h:3464:5: note: 'std::max'
3464 | max(initializer_list<_Tp> __l, _Compare __comp)
| ^~~
```
It is nothing to fix.
Regards,
Laurent
Pull Request resolved: facebook#1482
Reviewed By: yfeldblum
Differential Revision: D24757105
Pulled By: Orvid
fbshipit-source-id: 8a5382edbe5b7c11cace5a1cd4c0645dfd2a9d37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The compilation with the HEAD of gcc 11 fails:
It is nothing to fix.
Regards,
Laurent