Fixes necessary to build benchmark tests on OSX Monterey #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Orvid can we merge this one? |
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
042f4cc to
10faa51
Compare
added 2 commits
September 14, 2022 08:15
Apparently OSX doesn't implement barriers since it is an optional part of POSIX realtime threads extension, therefore we must test for its presence. This patch fixes the build of futures_benchmark for OSX Monterey with clang++ 13.1.6.
The benchmark for producer/consumer relies on a Linux-only API for setting process/thread affinity.
10faa51 to
0abbab0
Compare
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 19, 2022
Summary: ToT (Top of Tree) will fail to build if benchmarks are enabled (i.e. cmake ../ -DBUILD_BENCHMARKS=ON) on Monterey with clang++ 13.1.6. This patchset will fix the build. X-link: facebook/folly#1847 Reviewed By: Gownta Differential Revision: D39107587 Pulled By: Orvid fbshipit-source-id: 0bec33e64ee4d869fd00f8c77ae3aa8a0b0be9a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToT (Top of Tree) will fail to build if benchmarks are enabled (i.e. cmake ../ -DBUILD_BENCHMARKS=ON) on Monterey with clang++ 13.1.6.
This patchset will fix the build.