Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lexical-react] Bug Fix: LexicalMenu guard against undefined option when list shrinks #7899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

[lexical-react] Bug Fix: LexicalMenu guard against undefined option when list shrinks #7899

merged 4 commits into from
Oct 2, 2025
+26 −3

Conversation

@MRADULTRIPATHI
Copy link
Contributor

Title

[lexical-react] Bug Fix: guard against undefined option when list shrinks

PR Types:

Bug Fix

Description

  • Current behavior:
    When navigating the typeahead menu with ArrowDown/ArrowUp, if the list shrinks (e.g. type @p, move down to last option, then continue typing @poo), options[newSelectedIndex] can become undefined.
    This causes a crash:
  • Behavior after fix:
    Added a guard for missing option before accessing .ref, and safely reset the highlighted index when the list shrinks.
    This prevents crashes and ensures stable keyboard navigation in the typeahead menu.

Closes #7897

Test plan

Before

Steps:

  1. Open Playground
  2. Type @p to open mention list
  3. Use ArrowDown to select the last item
  4. Continue typing quickly (poo) so that the list shrinks
  5. Press ArrowDown

❌ Crash occurs in console:

After

Steps:

  1. Open Playground
  2. Type @p to open mention list
  3. Use ArrowDown to select the last item
  4. Continue typing quickly (poo) so that the list shrinks
  5. Press ArrowDown

✅ No crash, console stays clean, and list resets correctly.

Screenshot:

image

@meta-cla
Copy link

meta-cla bot commented Oct 1, 2025

Hi @MRADULTRIPATHI!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@vercel
Copy link

vercel bot commented Oct 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lexical Ready Ready Preview Comment Oct 2, 2025 6:24am
lexical-playground Ready Ready Preview Comment Oct 2, 2025 6:24am

@MRADULTRIPATHI
Copy link
Contributor Author

I have signed the CLA ✅
Please let me know if anything else is required. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2025
@meta-cla
Copy link

meta-cla bot commented Oct 1, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

etrepum
etrepum reviewed Oct 1, 2025
View reviewed changes
@MRADULTRIPATHI @etrepum
Apply suggestion from @etrepum
0976584 
Co-authored-by: Bob Ippolito <[email protected]>
@MRADULTRIPATHI MRADULTRIPATHI requested a review from etrepum October 2, 2025 06:11
@etrepum etrepum changed the title fix(LexicalMenu): guard against undefined option when list shrinks [lexical-react] Bug Fix: guard against undefined option when list shrinks Oct 2, 2025
etrepum
etrepum reviewed Oct 2, 2025
View reviewed changes
@MRADULTRIPATHI MRADULTRIPATHI requested a review from etrepum October 2, 2025 06:24
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Oct 2, 2025
@MRADULTRIPATHI MRADULTRIPATHI mentioned this pull request Oct 2, 2025
Closed
@MRADULTRIPATHI
Copy link
Contributor Author

Thanks again @etrepum
All suggested changes have been applied and tests are now passing.
When convenient, could you please review and merge this PR?

@etrepum etrepum changed the title [lexical-react] Bug Fix: guard against undefined option when list shrinks [lexical-react] Bug Fix: LexicalMenu guard against undefined option when list shrinks Oct 2, 2025
@etrepum etrepum added this pull request to the merge queue Oct 2, 2025
Merged via the queue into facebook:main with commit e60b434 Oct 2, 2025
42 checks passed
@etrepum etrepum mentioned this pull request Oct 2, 2025
Closed
@etrepum etrepum mentioned this pull request Oct 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: LexicalMenu reads option.ref when options[newSelectedIndex] is undefined

2 participants

@MRADULTRIPATHI @etrepum