Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Jan 19, 2023

There appears to be some issues with list-style-position: inside; on Safari, but we can probably just remove it as we're setting a margin-left any way. It's the same as putting the marker on the outside.

Closes #3752

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:48AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:48AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2023
@thegreatercurve thegreatercurve marked this pull request as ready for review January 19, 2023 21:21
@github-actions
Copy link

github-actions bot commented Jan 19, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.27 KB (0%) 506 ms (0%) 318 ms (+8.48% 🔺) 823 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.17 KB (0%) 784 ms (0%) 385 ms (+23.42% 🔺) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.14 KB (0%) 783 ms (0%) 449 ms (+30.75% 🔺) 1.3 s

@Amethystix
Copy link

Hi! Thanks for taking on this bug I reported so quickly; could you also apply the same style fix to ordered lists? It's the same problem there, you should just have to apply this to ol1 - ol5's markers and remove the same properties as that of unordered lists!

@thegreatercurve thegreatercurve merged commit 209b63a into main Jan 23, 2023
@thegreatercurve thegreatercurve deleted the bug/safari-markers branch February 3, 2023 13:31
@trueadm trueadm mentioned this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: [Playground] On Safari, using any list, cursor appears to the left of the ::marker until typing commences

5 participants