Fix is selected noop #3805
Merged
Fix is selected noop #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xical instance is made portable and its history state is saved to local react state
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trueadm
approved these changes
Feb 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request helps make editor instances more portable.
If an editor instance is moved around the DOM via drag and drop, setState functions that are nested inside a Lexical listener can result in a noop warning. While Lexical lives on, the React components surrounding it will not.
This pull request adds
isMountedto one spot to prevent this from happening.A previous PR accidentally snuck the same code into ImageComponent, which also needed this fix.