Switch source of truth for stdlibs#56
Merged
amyreese merged 1 commit intofacebook:mainfrom Apr 2, 2021
Merged
Conversation
I believe this one to both have better data and a better story around its source of truth for consistent updates from one py-version to the next.
Contributor
Author
|
This could probably use a test for |
amyreese
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a longer-term more reliable source of what top-level names come from stdlib. It includes many more names (mostly C extensions) that were missing before; see omnilib/stdlibs#1 for some comparisons vs other possible sources.
While we're at it, take a stance on
__main__being first-party code. This seems to be most commonly used for subcommands in click, or for logging, but seems fragile and untestable to me.