Generate skippable frame API #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b95dfbc to
76ab4b0
Compare
76ab4b0 to
5c41490
Compare
|
This looks good to me. Is there a particular use case that motivates adding this to the API? |
|
Was mentioned in #2275 that this might be a nice thing to have. |
In the future, if we ever come to settle on a few skippable frame IDs implying something meaningful, we could use an Speaking of "meaningful" skippable frame IDs, maybe we could consider those from |
Cyan4973
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZSTD_writeSkippableFrame(void* dst, size_t dstCapacity, const void* src, size_t srcSize, U32 magicVariant)Writes a skippable frame into
dstbuffer, usingsrccontent, and using one of the 16 available skippable frame magic numbers, controllable withmagicVariant. More detailed documentation inzstd.h.Test Plan: