Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@felixhandte
Copy link
Contributor

T106302328 wants us to update to "Meta Platforms, Inc. and affiliates".

In addition, I cleaned up some lagging year ranges, rewriting their ends to "present". If there's a reason it should be an explicit year though, I can switch to "2022".

@Cyan4973
Copy link
Contributor

It seems we were told at some point that present wasn't a valid year, and that an actual date was necessary.

@terrelln
Copy link
Contributor

It seems we were told at some point that present wasn't a valid year, and that an actual date was necessary.

That is not the latest guidance. We should move everything to a yearless copyright.

@terrelln
Copy link
Contributor

Just Copyright (c) Meta Platforms, Inc. and affiliates. is fine. https://www.internalfb.com/intern/wiki/Open_Source/Licenses/

@JunHe77
Copy link
Contributor

JunHe77 commented Jun 24, 2022

Sorry for just jumping in for a related copyright question. 😄
Is a new file, like the new .S file in #3155 required to share copyright with Meta? I saw the check in test-licens.py, but exceptions also exist.

@Tachi107
Copy link
Contributor

In addition, I cleaned up some lagging year ranges, rewriting their ends to "present". If there's a reason it should be an explicit year though, I can switch to "2022".

I don't want to mess with corporation policies, but I'd recommend giving this blog post a quick read - in short routinely bumping copyright years isn't really that worth it :)

```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora \) -prune -o -type f);
do
  sed -i 's/Facebook, Inc\./Meta Platforms, Inc. and affiliates./' $f;
done
```
```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora -o -path ./tests/regression/data-cache -o -path ./tests/regression/cache \) -prune -o -type f);
do
  sed -i 's/\-2021/-present/' $f;
done

g co HEAD -- .github/workflows/dev-short-tests.yml # fix bad match
```
Apparently it's better. Somehow.

```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora -o -path ./tests/regression/data-cache -o -path ./tests/regression/cache \) -prune -o -type f); do echo $f; sed -i 's/\-present/-2022/' $f; done

g co HEAD -- build/meson/
```
```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora -o -path ./tests/regression/data-cache -o -path ./tests/regression/cache \) -prune -o -type f); do sed -i '/Copyright .* \(Yann Collet\)\|\(Meta Platforms\)/ s/Copyright .*/Copyright (c) Meta Platforms, Inc. and affiliates./' $f; done

git checkout HEAD -- build/VS2010/libzstd-dll/libzstd-dll.rc build/VS2010/zstd/zstd.rc tests/test-license.py contrib/linux-kernel/test/include/linux/xxhash.h examples/streaming_compression_thread_pool.c lib/legacy/zstd_v0*.c lib/legacy/zstd_v0*.h
nano ./programs/windres/zstd.rc
nano ./build/VS2010/zstd/zstd.rc
nano ./build/VS2010/libzstd-dll/libzstd-dll.rc
```
@felixhandte felixhandte force-pushed the update-copyright-company branch from a7d908c to 5d693cc Compare December 20, 2022 17:52
@Cyan4973
Copy link
Contributor

There is no more reference of any year in the copyright header.
Is that a wanted outcome ?

@felixhandte
Copy link
Contributor Author

@Cyan4973, that seems to be the guidance.

@felixhandte felixhandte merged commit f302ad8 into facebook:dev Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants