✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	e011624
🔍 Latest deploy log	https://app.netlify.com/projects/fakerjs/deploys/6930ce412acbbb00084708fb
😎 Deploy Preview	https://deploy-preview-3259.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.97%. Comparing base (78c892b) to head (e011624).

@@            Coverage Diff             @@
##             next    #3259      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2995     2995              
  Lines      236243   236266      +23     
  Branches      941      943       +2     
==========================================
+ Hits       236186   236208      +22     
- Misses         57       58       +1     

I understand wanting to keep this PR small but I think it's difficult to decide if this is the right approach without reviewing what locale files will need to be updated too.

To clarify with this approach would we require the "generic", "female" and "male" options never have any items in common?

Team Decision

We will change the sexType method to return all SexType values.
A parameter includeGeneric: boolean = false can be used to control the inclusion of generic in the results.
We will check in v10 whether we want to change the default for includeGeneric based on code usage?

ST-DDT: Will create a stacked PR for the locale changes.

• Things in both female and male -> generic
• Things in generic -> remove from female and male
• Without manual changes
• The stacked PR might be later split in smaller chunks to help with reviewability

ST-DDT: Will create a stacked PR for the locale changes.

[...]

• Without manual changes
• The stacked PR might be later split in smaller chunks to help with reviewability

@xDivisionByZerox Currently, the person files aren't sorted, so this by itself causes a massive diff.
Should we sort them first? Would you like to create a PR for that or should I?

(Maybe start with only sorting first, because the cleanup PR will use the list for filtering: See #3266 (comment))

Updated the distribution to match the result from our team meeting.

• refactor(locale): filter and cleanup PersonEntryDefintions data #3266 (comment)

Ready for review.

Read for review

Looks good to me, but I think let's wait till after 10.2.0 is released to merge it.

Then this as well as the follow on locale changes can be part of 10.3.0.

Thanks for the input @matthewmayer 👍
I'll mark this PR with do NOT merge yet Do not merge this PR into the target branch yet to prevent us from merging it for now.