Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Adds Smashing Pumpkins to the Music module#2817

Merged
stefannibrasil merged 1 commit intofaker-ruby:mainfrom
redconfetti:smashing-pumpkins
Nov 1, 2023
Merged

Adds Smashing Pumpkins to the Music module#2817
stefannibrasil merged 1 commit intofaker-ruby:mainfrom
redconfetti:smashing-pumpkins

Conversation

@redconfetti
Copy link
Contributor

@redconfetti redconfetti commented Aug 29, 2023 •
edited
Loading

Adding the Smashing Pumpkins to the Music module

Description:
New Faker::Music::SmashingPumpkins class that contains the following methods:

musician - will return the name of a band member (former or current)
album - will return the name of one of the band's albums
song - will return the name of one of their songs
lyric - will return a lyric from one of their songs

Faker::Music::SmashingPumpkins.musician #=> "Billy Corgan"
Faker::Music::SmashingPumpkins.musician #=> "James Iha"
Faker::Music::SmashingPumpkins.album #=> "Machina/The Machines of God"
Faker::Music::SmashingPumpkins.album #=> "American Gothic"
Faker::Music::SmashingPumpkins.song #=> "Fireflies"
Faker::Music::SmashingPumpkins.song #=> "Cottonwood Symphony"
Faker::Music::SmashingPumpkins.song #=> "Annie-Dog"
Faker::Music::SmashingPumpkins.song #=> "Gossamer"
Faker::Music::SmashingPumpkins.lyric #=> "We all want to hold in the everlasting gaze, enchanted in the rapture of his sentimental sway, but underneath the wheels lie the skulls of every cog, the fickle fascination of an everlasting God"
Faker::Music::SmashingPumpkins.lyric #=> "And the embers never fade, in your city by the lake. The place where you were born"
Faker::Music::SmashingPumpkins.lyric #=> "So meets the final coda of a vinyl storm, one more cherry cola to lift up her dead arms. A dream of soft focus, sunsets filters through the dim. We are losing contact as she dials it in"

stefannibrasil
stefannibrasil reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @redconfetti please review the general guidelines for contributing to faker: https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#general-guidelines

I only gave a quick review and there are some words that we don't allow.

Additionally, could you half the number of songs and lyric? We don't need to add all of them, it's a lot to review and maintain. Thanks!

@redconfetti
Copy link
Contributor Author

redconfetti commented Sep 7, 2023

@stefannibrasil - The guidelines state:

Don't include hurtful language that can convey exclusionary behavior, such as racism, sexism, homophobia. Be considerate and mindful of others.

I'm not sure which words you would categorize under this, but I've removed what I think might be vaguely categorized as this.

I reduced the songs to ones on primary album releases. Also reduced lyrics to ones most popular.

stefannibrasil
stefannibrasil reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @redconfetti thank you for your patience, I was on PTO. Yes, you're right -- it's a bit ambiguous. We're still working on that, so I appreciate your understanding.

The file still has a lot of lyrics so it was a bit hard to review still. The first time, I remember finding words such as "wh****", which is ambiguous. Thanks for giving it another round of review.

I left just one remaining suggestion. I worry folks who have had situations with the phrase could have a bad experience using the library.

Once that one is removed, this is good to go. Thank you!

@stefannibrasil stefannibrasil merged commit 555d9fa into faker-ruby:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redconfetti @stefannibrasil