feat: add danish country code#2818
Merged
stefannibrasil merged 3 commits intofaker-ruby:mainfrom Sep 7, 2023
Merged
Conversation
lib/locales/da-DK.yml
Outdated
| - "#{first_name} #{last_name} #{last_name}" | ||
| - "#{first_name} #{last_name} #{last_name}" | ||
|
|
||
| country_code: '45' |
Contributor
There was a problem hiding this comment.
Suggested change
| country_code: '45' | |
| country_code: ['45'] |
Did this work for you as it is? Looking at the other locales, it seems the generator expects this value to be in an array 🤔
Contributor
Author
There was a problem hiding this comment.
It's working with the sting. See 520f812
Contributor
There was a problem hiding this comment.
ah, thank you for confirming! Do you mind adding an array just to keep the pattern? If in the future we refactor these files, it's easier if they all follow the same pattern. Thanks!
vbrazo
reviewed
Sep 6, 2023
Member
vbrazo
left a comment
There was a problem hiding this comment.
could you please add a test for your implementation?
Contributor
Author
sure. please check 520f812 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the country code for danish locales is missing.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]