Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor!: reduce copy of location #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

refactor!: reduce copy of location #14

merged 2 commits into from
Oct 27, 2025

Conversation

@andylokandy
Copy link
Contributor

No description provided.

tisonkun
tisonkun approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in the previous version we have a logic to prefer error's provided Location.

exn/exn/src/impls/mod.rs

Lines 49 to 57 in 3fb0377

#[track_caller]
pub fn new(error: E) -> Self {
#[track_caller]
fn make_location(err: &(impl std::error::Error + ?Sized)) -> Location<'static> {
match std::error::request_ref::<Location>(err) {
Some(loc) => *loc,
None => *Location::caller(),
}
}

I understand that it requires unstable feature so we remove it now. But not sure if it's still valuable when avaiable on stable.

@tisonkun tisonkun merged commit 3dd4384 into fast:main Oct 27, 2025
6 checks passed
@tisonkun tisonkun changed the title chore!: reduce copy of location refactor!: reduce copy of location Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andylokandy @tisonkun