Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(oneshot): implement Debug manually #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tisonkun merged 2 commits into from
Jan 3, 2026
Merged

refactor(oneshot): implement Debug manually #100

tisonkun merged 2 commits into from
Jan 3, 2026

Conversation

@Paraworker
Copy link
Contributor

@Paraworker Paraworker commented Dec 30, 2025

Replace derived Debug with a manual implementation to avoid an unnecessary T: Debug bound.

@Paraworker Paraworker changed the title refactor(oneshot) implement Debug manually refactor(oneshot): implement Debug manually Dec 30, 2025
tisonkun
tisonkun approved these changes Jan 3, 2026
View reviewed changes
Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks reasonable.

Next time, you can mention (@) me as a reviewer. Even if I watch this repo, I can miss notifications, especially when the watch notification doesn't go directly to my mailbox, so some setups don't work.

@tisonkun
fmt
71cbdd8 
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun enabled auto-merge (squash) January 3, 2026 15:17
@tisonkun tisonkun merged commit da9b891 into fast:main Jan 3, 2026
9 checks passed
@tisonkun
Copy link
Collaborator

tisonkun commented Jan 3, 2026

Let me know if you're waiting for a new release. The next release would be 0.6.0 and I'd do a review for any other pending break changes.

Also I'm glad to know if you're using mea in any of your projects @Paraworker.

@Paraworker
Copy link
Contributor Author

Paraworker commented Jan 4, 2026

Yes, I’m planning to use mea::oneshot in async-join as a replacement for futures::oneshot.

The API in mea fits my use case well, and the code quality looks solid. I’ll keep an eye on the project.

@tisonkun
Copy link
Collaborator

tisonkun commented Jan 4, 2026

@Paraworker mea 0.6.0 has been released - https://crates.io/crates/mea/0.6.0

@Paraworker Paraworker deleted the oneshot-debug-impl branch January 4, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Paraworker @tisonkun