feat: change @fastify/restartable api #40
Conversation
example.mjs
Outdated
| port: 3000, | ||
| app: myApp | ||
| }) | ||
| const app = await restartable(createApp, fastify, { logger: true }) |
There was a problem hiding this comment.
| const app = await restartable(createApp, fastify, { logger: true }) | |
| const app = await restartable(createApp, { logger: true }) |
I think this API would be better
There was a problem hiding this comment.
@fastify/restartable should not depend on a specific version of fastify. That means users should be able to pass the fastify factory.
test/index.test.js
Outdated
| teardown(stop) | ||
|
|
||
| const { address, port } = await listen() | ||
| const host = await app.listen({ host: '127.0.0.1', port: 5844 }) |
There was a problem hiding this comment.
Can we avoid hard coding ports numbers? It's more likely to cause flaky tests.
There was a problem hiding this comment.
I can extract them into the variable if that what you mean, but I can't set it to 0 like in other tests because here I'm testing that restartable fastify starts server on the port I pass.
There was a problem hiding this comment.
It's probably fine. Maybe use the same port across all of these tests then and make sure they never get run in parallel. A COMMON_PORT variable sounds good.
README.md
Outdated
|
|
||
| ```js | ||
| import { start } from '@fastify/restartable' | ||
| import { restartable } from './index.js' |
There was a problem hiding this comment.
| import { restartable } from './index.js' | |
| import { restartable } from '@fastify/restartable' |
5e8649f to
d982948
Compare
d96f60c to
8108e91
Compare
No description provided.