Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Makefile: when building binary, depend on .go files #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 1 commit into from
Jun 23, 2022
+3 −1
Merged

Makefile: when building binary, depend on .go files #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ LDFLAGS = -ldflags "\
-X 'github.com/fastly/cli/pkg/revision.Environment=${CLI_ENV}' \
"

fastly:
GO_FILES = $(shell find cmd pkg -type f -name '*.go')
Copy link
Collaborator

@Integralist Integralist Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly there are 482 go files in this project 😅

Copy link
Member Author

@joeshaw joeshaw Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was a little worried about that but I didn't see a noticeable slowdown in builds


fastly: $(GO_FILES)
@go build -trimpath $(LDFLAGS) -o "$@" ./cmd/fastly

# useful for attaching a debugger such as https://github.com/go-delve/delve
Expand Down