when updating config due to version change, block command on it #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally the CLI updates the config in the background for subsequent executions. However, if the version changes we need to get the updated config in place before we execute the command.
Member
Author
|
An alternative approach I explored was having the diff --git pkg/commands/update/root.go pkg/commands/update/root.go
index d832861..a434f82 100644
--- pkg/commands/update/root.go
+++ pkg/commands/update/root.go
@@ -5,6 +5,7 @@ import (
"fmt"
"io"
"os"
+ "os/exec"
"path/filepath"
"github.com/fastly/cli/pkg/cmd"
@@ -122,6 +123,15 @@ func (c *RootCommand) Exec(in io.Reader, out io.Writer) error {
}
}
+ progress.Step("Testing binary...")
+ if err := exec.Command(currentPath, "version").Run(); err != nil {
+ c.Globals.ErrLog.AddWithContext(err, map[string]interface{}{
+ "Executable": currentPath,
+ })
+ progress.Fail()
+ return fmt.Errorf("error running new binary: %w", err)
+ }
+
progress.Done()
text.Success(out, "Updated %s to %s.", currentPath, latest)The problem with this is that there's a race because the old code could write out the config file after the new code does because it's done in the background. |
Integralist
approved these changes
Jul 28, 2022
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
LGTM. I think for these occasions (i.e. when updating to a new CLI version) it's OK to block for the config 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the CLI updates the config in the background for subsequent
executions. However, if the version changes we need to get the updated
config in place before we execute the command.