Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Secret Store support #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Integralist merged 12 commits into from
Jan 24, 2023
Merged

Add Secret Store support #717

Integralist merged 12 commits into from
Jan 24, 2023

Conversation

@awilliams-fastly
Copy link
Collaborator

@awilliams-fastly awilliams-fastly commented Nov 21, 2022 •
edited
Loading

Adds the following commands:

fastly secret-store
  create    Create a new secret store
  describe  Retrieve a single secret store
  delete    Delete a secret store
  list      List secret stores

fastly secret-store-entry
  create    Create a new secret within specified store
  describe  Retrieve a single secret
  delete    Delete a secret
  list      List secrets within a specified store

@awilliams-fastly awilliams-fastly force-pushed the awilliams/secret-store branch 7 times, most recently from 6a30f3e to 4d39cc8 Compare November 28, 2022 16:43
@awilliams-fastly awilliams-fastly marked this pull request as ready for review November 28, 2022 17:06
Integralist
Integralist reviewed Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awilliams-fastly for opening this PR. The code looks great.

I just have some requested changes for the sake of consistency with the rest of the CLI code base.

pkg/commands/secretstore/secret_test.go
}
doesNotExistFile := path.Join(tmpDir, "DOES-NOT-EXIST")

scenarios := []struct {
Copy link
Collaborator

@Integralist Integralist Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for this PR, but if you have any experience with the new fuzzing features in go1.18 it would be great to see an example test that utilises that feature.

@awilliams-fastly
Copy link
Collaborator Author

awilliams-fastly commented Nov 29, 2022

Thanks @Integralist for the review.

I've made updates to go along with your comments. In addition, I've changed the two get commands to instead be describe (with get alias) for consistency with other commands.

@Integralist Integralist added enhancement New feature or request DO NOT MERGE YET labels Nov 30, 2022
Integralist
Integralist reviewed Nov 30, 2022
View reviewed changes
Integralist
Integralist approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Approved, but as discussed internally we won't merge this PR yet until we're ready to release.

@awilliams-fastly
Copy link
Collaborator Author

awilliams-fastly commented Dec 2, 2022

@Integralist Thanks for the review

awilliams-fastly added a commit that referenced this pull request Dec 5, 2022
@awilliams-fastly
Add support for TOML secret_store section
42f328d 
Viceroy is being updated with support for a new `local_server.secret_store` configuration section.
This change adds support for this new section in the manifest.

Viceroy change:
fastly/Viceroy#210

Related change:
#717
awilliams-fastly added a commit that referenced this pull request Dec 5, 2022
@awilliams-fastly
Add support for TOML secret_store section
419a843 
Viceroy is being updated with a new `local_server.secret_store` configuration section. Viceroy change:
fastly/Viceroy#210

This change adds support for the new Secret Store configuration section.

Related change:
#717
@awilliams-fastly awilliams-fastly mentioned this pull request Dec 5, 2022
Merged
awilliams-fastly added a commit that referenced this pull request Dec 6, 2022
@awilliams-fastly
Add support for TOML secret_store section (#726)
be77d21 
Viceroy is being updated with a new `local_server.secret_store` configuration section. Viceroy change:
fastly/Viceroy#210

This change adds support for the new Secret Store configuration section.

Related change:
#717
@Integralist Integralist force-pushed the main branch 8 times, most recently from e474f85 to 788ba3e Compare January 3, 2023 21:01
awilliams-fastly and others added 11 commits January 19, 2023 12:54
@awilliams-fastly
Add Secret Store support
a881457 
Adds the following commands:

    fastly secret-store
      create  Create secret store
      get     Get secret store
      delete  Delete secret store
      list    List secret stores

    fastly secret-store-entry
      create  Create secret
      get     Get secret
      delete  Delete secret
      list    List secrets
@awilliams-fastly @Integralist
Remove extraneous comment.
714ec6c 
Co-authored-by: Mark McDonnell <[email protected]>
@awilliams-fastly @Integralist
Re-order fields for consistency and readability
8a61c42 
Co-authored-by: Mark McDonnell <[email protected]>
@awilliams-fastly @Integralist
Consistent formatting.
cddf27a 
Co-authored-by: Mark McDonnell <[email protected]>
@awilliams-fastly @Integralist
Remove else block
0c85bf4 
Co-authored-by: Mark McDonnell <[email protected]>
@awilliams-fastly @Integralist
Add TODO
1883923 
Co-authored-by: Mark McDonnell <[email protected]>
@awilliams-fastly @Integralist
Comment exported function.
cc4e9ec 
Co-authored-by: Mark McDonnell <[email protected]>
@awilliams-fastly
Change formatting and ordering for consistency with other commands
24bd156
@awilliams-fastly
Use 'describe' instead of 'get' for consistency
a6080b0
@awilliams-fastly
Fix error text
8e6d490
@awilliams-fastly
Consider auto-yes in list cmds; add RegisterFlagInt to Base
57fbb1f
@awilliams-fastly awilliams-fastly mentioned this pull request Jan 20, 2023
Merged
@Integralist Integralist merged commit 4dad65d into main Jan 24, 2023
@Integralist Integralist deleted the awilliams/secret-store branch January 24, 2023 16:37
@awilliams-fastly
Copy link
Collaborator Author

awilliams-fastly commented Jan 24, 2023

Thank you @Integralist !

awilliams-fastly added a commit that referenced this pull request Apr 12, 2023
@awilliams-fastly
feat(compute/deploy): add Secret Store to manifest [setup]
8bffeeb 
Adds ability to define Secret Stores in the `[setup]` section of a `fastly.toml` config file.
The user will be prompted to create the defined stores and secrets on creation of a service when using `fastly compute deploy`.

Related: #717, #764
awilliams-fastly added a commit that referenced this pull request Apr 12, 2023
@awilliams-fastly
feat(compute/deploy): add Secret Store to manifest [setup]
55e4fc2 
Adds ability to define Secret Stores in the `[setup]` section of a `fastly.toml` config file.
The user will be prompted to create the defined stores and secrets on creation of a service when using `fastly compute deploy`.

Related: #717, #764
awilliams-fastly added a commit that referenced this pull request Apr 12, 2023
@awilliams-fastly
feat(compute/deploy): add Secret Store to manifest [setup]
827d439 
Adds ability to define Secret Stores in the `[setup]` section of a `fastly.toml` config file.
The user will be prompted to create the defined stores and secrets on creation of a service when using `fastly compute deploy`.

Related: #717, #764
awilliams-fastly added a commit that referenced this pull request Apr 13, 2023
@awilliams-fastly
feat(compute/deploy): add Secret Store to manifest [setup] (#769)
e977ad3 
Adds ability to define Secret Stores in the `[setup]` section of a `fastly.toml` config file.
The user will be prompted to create the defined stores and secrets on creation of a service when using `fastly compute deploy`.

Related: #717, #764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Integralist Integralist Integralist approved these changes

@joeshaw joeshaw Awaiting requested review from joeshaw

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@awilliams-fastly @Integralist @philippschulte