Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use DevHub endpoint for acquiring CLI/Viceroy metadata #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Integralist merged 26 commits into from
Jan 3, 2023
Merged

Use DevHub endpoint for acquiring CLI/Viceroy metadata #739

Integralist merged 26 commits into from
Jan 3, 2023

Conversation

@Integralist
Copy link
Collaborator

@Integralist Integralist commented Dec 15, 2022 •
edited
Loading

Problem: The CLI often triggers GitHub rate limit errors.
Solution: Have the DevHub acquire/cache the necessary metadata needed to download binaries from GitHub.

Notes:
I've tested the code manually and you can see from the following screenshot that the upgrade of the Viceroy version is happening successfully via the DevHub API endpoint:
Screenshot 2022-12-15 at 15 36 35

Fixes #744

@Integralist Integralist added the enhancement New feature or request label Dec 15, 2022
This was referenced Dec 15, 2022
Closed
Closed
@Integralist
style(pkg/app): reorder defined types so symbol AST is more logical
9457727
@Integralist
build(pkg/app): ignore semgrep errors for assigning to global
1ba6232
@Integralist
refactor(pkg/github): add type comments for LSP client hover information
e35c287
@Integralist
feat(pkg/github): replace implementation with DevHub endpoint
71f0855
@Integralist
refactor(pkg/github): rename GitHub type to avoid stutter
e789ada
@Integralist
refactor(main): inline variable declarations
3db59d8
@Integralist
refactor: rename cliVersioner
40b8c0f
@Integralist
refactor: rename viceroyVersioner
589e981
@Integralist
build(pkg/commands/version): ignore semgrep error for exec.Command call
70fb8f5
@Integralist
refactor(pkg/mock): remove unused fields
aaef412
@Integralist
refactor: rename Versioner.Binary
d6f1d21
@Integralist
refactor(pkg/github): rename Versioner
9b6024e
@Integralist
refactor(pkg/github): rename dir variable
fb59283
@Integralist
refactor(pkg/commands/update): rename latestPath variable
8bc5d77
@Integralist
refactor(pkg/github): extract inline logic to separate functions
0ba2509
@Integralist
docs(pkg/github) add documentation to extracted functions
5a3ea9b
@Integralist
refactor(pkg/github): avoid bad return pattern
6de6006
@Integralist
docs(pkg/errors): add comments to RemediationError type
df5d6ba
@Integralist
style(pkg/github): move functions around to align with symbols AST
5f5b0eb
@Integralist
refactor(pkg/github): avoid mutation side-effect
afbb7f0
@Integralist
refactor(pkg/github): add context to error messages
298a7a5
@Integralist
docs(pkg/github): document end-to-end integration test
33428b5
@Integralist
build(pkg/commands/update): ignore semgrep invalid-usage-of-modified-…
8ea70a1 
…variable
@Integralist
refactor(pkg/commands/update): rename variable
1555a8e
@Integralist Integralist force-pushed the integralist/versioner branch from addd9e7 to 1555a8e Compare January 3, 2023 16:11
@Integralist Integralist merged commit a709876 into main Jan 3, 2023
@Integralist Integralist deleted the integralist/versioner branch January 3, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@triblondon triblondon triblondon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rate limiting from Github when running fastly compute serve

3 participants

@Integralist @triblondon