Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove user environment validation logic #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 24 commits into from
Feb 6, 2023
Merged

Remove user environment validation logic #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8a89957
refactor(compute/init): remove unused argument
Integralist Jan 30, 2023
a2c6d55
refactor(compute/init): rename prompt functions for clarity
Integralist Jan 30, 2023
73810b8
refactor(compute/init): avoid invalid-usage-of-modified-variable issues
Integralist Jan 30, 2023
0774643
refactor(compute/build): move package name logic into separate function
Integralist Jan 30, 2023
5a12b8b
refactor(compute/build): move toolchain logic into separate function
Integralist Jan 30, 2023
3bf6614
refactor(compute/build): move language logic into separate function
Integralist Jan 30, 2023
31052be
refactor(compute/build): move bin directory logic into separate function
Integralist Jan 30, 2023
51a2d89
refactor(compute): remove unused IncludeFiles
Integralist Jan 30, 2023
31e45ac
refactor(compute): remove --skip-verification
Integralist Jan 30, 2023
fc95d60
refactor(compute/init): remove unused args from NewLanguages
Integralist Jan 30, 2023
65c9b4b
refactor(compute): restructure types
Integralist Jan 30, 2023
b239b5f
refactor(compute): remove methods from Toolchain interface
Integralist Jan 30, 2023
249e031
refactor(compute/init): simplify/clean-up init logic
Integralist Jan 30, 2023
17726c1
fix(compute): tests
Integralist Jan 30, 2023
710f722
feat(compute/build): update Rust build logic
Integralist Jan 31, 2023
6909890
feat(compute/build): update Go build logic
Integralist Jan 31, 2023
a391eb8
feat(compute/build): update JavaScript build logic
Integralist Jan 31, 2023
88ec014
refactor(compute/toolchain): clean-up unused types and functions
Integralist Jan 31, 2023
818e80b
feat(compute/build): clean-up tests
Integralist Feb 1, 2023
b3a6fef
refactor(compute/build): implement a cleaner toolchain abstraction
Integralist Feb 1, 2023
4d75162
fix: support for go1.20.0
Integralist Feb 6, 2023
be74e8d
fix(compute/build): correct the src directory for assemblyscript
Integralist Feb 6, 2023
c28f20c
docs(build): reference URL for clearing GitHub Actions cache
Integralist Feb 6, 2023
5c9c7c5
fix: support for go1.19.0
Integralist Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/pr_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: 1.18.x
go-version: 1.19.x
# NOTE: Manage GitHub Actions cache https://github.com/fastly/cli/actions/caches
# This is useful if you need to clear the cache when a dependency doesn't update correctly.
- name: "Restore golang bin cache"
id: go-bin-cache
uses: actions/cache@v3
Expand Down Expand Up @@ -81,7 +83,7 @@ jobs:
strategy:
matrix:
tinygo-version: [0.26.0]
go-version: [1.18.x]
go-version: [1.19.x]
node-version: [18]
rust-toolchain: [stable]
platform: [ubuntu-latest, macos-latest, windows-latest]
Expand Down Expand Up @@ -152,4 +154,4 @@ jobs:
- name: Build docker images
run: |
for dockerFile in Dockerfile*; do docker build -f $dockerFile . ; done

2 changes: 1 addition & 1 deletion .github/workflows/tag_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: "Install Go"
uses: actions/setup-go@v3
with:
go-version: '1.18.x'
go-version: '1.19.x'
- name: "Set GOHOSTOS and GOHOSTARCH"
run: echo "GOHOSTOS=$(go env GOHOSTOS)" >> $GITHUB_ENV && echo "GOHOSTARCH=$(go env GOHOSTARCH)" >> $GITHUB_ENV
- name: "Install Rust"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ RELEASE_CHANGELOG.md
rust-toolchain
.cargo
**/node_modules
pkg/commands/compute/package-lock.json

# Binaries for programs and plugins
*.exe
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ all: config dependencies tidy fmt vet staticcheck gosec test build install
.PHONY: dependencies
dependencies:
$(GO_BIN) install github.com/securego/gosec/v2/cmd/gosec@latest
$(GO_BIN) install honnef.co/go/tools/cmd/staticcheck@latest
$(GO_BIN) install honnef.co/go/tools/cmd/staticcheck@2023.1
$(GO_BIN) install github.com/mgechev/revive@latest
$(GO_BIN) install github.com/goreleaser/[email protected]

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/fastly/cli

go 1.18
go 1.19

require (
github.com/Masterminds/semver/v3 v3.2.0
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/undocumented/undocumented.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func Get(host, path, token string, c api.HTTPClient) (data []byte, err error) {
}
return data, NewError(err, 0)
}
defer res.Body.Close()
defer res.Body.Close() // #nosec G307

if res.StatusCode != http.StatusOK {
return data, NewError(fmt.Errorf("non-2xx response"), res.StatusCode)
Expand Down
Loading