Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build with Go 1.19 #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joeshaw wants to merge 1 commit into from
Closed

build with Go 1.19 #790

joeshaw wants to merge 1 commit into from

Conversation

@joeshaw
Copy link
Member

@joeshaw joeshaw commented Feb 3, 2023

Did this because CI started failing with tools saying, "module requires Go 1.19": https://github.com/fastly/cli/actions/runs/4087575206/jobs/7048248681

Also, as of Go 1.20's release, 1.18 is now unsupported. Happy to bump this to 1.20 if that's desired, BTW.

@joeshaw joeshaw mentioned this pull request Feb 3, 2023
Merged
@Integralist
Copy link
Collaborator

Integralist commented Feb 6, 2023

👋🏻 thanks @joeshaw

Might as well bump to 1.20 as long as the various CI/tools are supported (e.g. staticcheck etc)

Integralist
Integralist approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve to unblock but if this works with 1.20 (e.g. all the required tooling, see make dependencies target) then we should bump to latest instead.

@fgsch
Copy link
Member

fgsch commented Feb 6, 2023

If we switch to 1.20 we will get native DNS resolution in most (all?) platforms - that should fix some of the known issues.

@Integralist
Copy link
Collaborator

Integralist commented Feb 6, 2023

@fgsch yes, that's a good point actually. That pesky DNS problem that's plagued most of us at one time of another should finally be put to bed 😬

@Integralist Integralist added the enhancement New feature or request label Feb 6, 2023
@Integralist
Copy link
Collaborator

Integralist commented Feb 6, 2023

BTW I tried bumping to 1.20.0 and I'm seeing:

staticcheck ./{cmd,pkg}/...
-: cannot import "internal/cpu" (unexpected escape sequence in export data), possibly version skew - reinstall package (compile)
-: cannot import "internal/goarch" (unknown bexport format version -1 ("u\x01\x00\x00\x00\x00\x00\x00\x003\x00\x00\x005\x00\x00\x007\x00\x00\x008\x00\x00\x00e\x00\x00\x00j\x00\x00\x00\x97\x00\x00\x00\xc4\x00\x00\x00\xf1\x00\x00\x00\xf1\x00\x00\x00\x00\x00\x00\x00\x06\x00\x00\x00\x15\x00\x00\x00:\x00\x00\x00H\x00\x00\x00M\x00\x00\x00P\x00\x00\x00U\x00\x00\x00_\x00\x00\x00h\x00\x00\x00{\x00\x00\x00\xa7\x00\x00\x00\xac\x00\x00\x00\xb2\x00\x00\x00\xb6\x00\x00\x00\xc0\x00\x00\x00\xc5\x00\x00\x00\xcc\x00\x00\x00\xd6\x00\x00\x00\xdb\x00\x00\x00\xe2\x00\x00\x00\xeb\x00\x00\x00\xf2\x00\x00\x00\xfb\x00\x00\x00\x01\x01\x00\x00\t\x01\x00\x00\x13\x01\x00\x00\x1e\x01\x00\x00+\x01\x00\x003\x01\x00\x008\x01\x00\x00?\x01\x00\x00H\x01\x00\x00O\x01\x00\x00X\x01\x00\x00^\x01\x00\x00e\x01\x00\x00l\x01\x00\x00u\x01\x00\x00{\x01\x00\x00\x82\x01\x00\x00\x86\x01\x00\x00\x8c\x01\x00\x00\x98\x01\x00\x00\xa1\x01\x00\x00\xa6\x01\x00\x00\xad\x01\x00\x00\xb4\x01\x00\x00\xb9\x01\x00\x00\xc3\x01\x00\x00\xc7\x01\x00\x00\xae\x02\x00\x00\xb1\x02\x00\x00\xb6\x02\x00\x00\xbb\x02\x00\x00\xc5\x02\x00\x00\xcd\x02\x00\x00\xd5\x02\x00\x00\xdd\x02\x00\x00\xe5\x02\x00\x00\xed\x02\x00\x00\xf5\x02\x00\x00\xfd\x02\x00\x00\x05\x03\x00\x00\r\x03\x00\x00\x15\x03\x00\x00\x1d\x03\x00\x00%\x03\x00\x00-\x03\x00\x005\x03\x00\x00=\x03\x00\x00E\x03\x00\x00M\x03\x00\x00U\x03\x00\x00]\x03\x00\x00e\x03\x00\x00m\x03\x00\x00u\x03\x00\x00}\x03\x00\x00\x85\x03\x00\x00\x8d\x03\x00\x00\x95\x03\x00\x00\x9d\x03\x00\x00\xa5\x03\x00\x00\xad\x03\x00\x00\xb5\x03\x00\x00\xbd\x03\x00\x00\xc5\x03\x00\x00\xcd\x03\x00\x00\xd5\x03\x00\x00\xdd\x03\x00\x00\xe5\x03\x00\x00\xed\x03\x00\x00\xf5\x03\x00\x00\xfd\x03\x00\x00\x05\x04\x00\x00\r\x04\x00\x00\x15\x04\x00\x00\x1d\x04\x00\x00%\x04\x00\x00-\x04\x00\x004\x04\x00\x007\x04\x00\x00:\x04\x00\x00=\x04\x00\x00@\x04\x00\x00N\x04\x00\x00Z\x04\x00\x00h\x04\x00\x00v\x04\x00\x00\x84\x04\x00\x00\x92\x04\x00\x00\xa2\x04\x00\x00\xb2\x04\x00\x00\xc0\x04\x00\x00\xce\x04\x00\x00\xdc\x04\x00\x00\xea\x04\x00\x00\xf8\x04\x00\x00\x06\x05\x00\x00\x14\x05\x00\x00\"\x05\x00\x000\x05\x00\x00>\x05\x00\x00L\x05\x00\x00Z\x05\x00\x00h\x05\x00\x00v\x05\x00\x00\x84\x05\x00\x00\x92\x05\x00\x00\xa0\x05\x00\x00\xae\x05\x00\x00\xbc\x05\x00\x00\xca\x05\x00

@Integralist
Copy link
Collaborator

Integralist commented Feb 6, 2023

Looks like TinyGo requires no greater than 1.19
Screenshot 2023-02-06 at 12 36 18

@Integralist
Copy link
Collaborator

Integralist commented Feb 6, 2023

I'm going to close this PR as the recently merged PR below has these (and other) changes...
#785

@Integralist Integralist closed this Feb 6, 2023
@Integralist Integralist deleted the joeshaw/bump-go-version branch February 6, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Integralist Integralist Integralist approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joeshaw @Integralist @fgsch